Update SpaceHardware enum
#1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophe-rannou
approved these changes
Nov 3, 2023
|
Thanks for the quick review :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(raised on slack -internal link- by @abhishekkrthakur)
Current
SpaceHardwareenum is outdated. This PR updates it with"zero-a10g","a10g-largex2"and"a10g-largex4". Note: even when not added to the enum, users can still sets them using a simple string.I chose to add the
zero-a10g(cc @cbensimon) even though it is still in restricted access. Shouldn't be much of a problem (I don't think this API is much used by non-HF users) and at least it will be forward compatible.cc @christophe-rannou who updated this list in the backend recently.